DSL to JS code generation changes in preparation for joins on the client #370
+88
−34
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
|
Summary clarifcation: Performance optimization for client-side custom functions. This PR introduces vectorized evaluation for custom functions to improve execution speed. Instead of evaluating elements individually, the system now performs vectorized operations. Key Details: Scope: This optimization currently applies only to custom functions (aliased) defined on the server. Implementation: The optimization is handled via PythonAST on the server side. Unit test for the evailaution is work in progress. |
Owner
|
Merging but unit test needed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR:
Adds support for arrays in parameterArray
Optimizes custom JS function generated from the DSL, factor 20
TODO: Add more tests, add joins on the client using this